Remove re-classification to Liquidity order #2313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
approved these changes
Jan 22, 2024
|
I don't think we want to merge this yet. If we don't classify such orders as liquidity order there is a risk of getting spammed with nifty stable2stable coin trades again and I think we actually found the culprit of why more orders are now deemed liquidity orders. |
|
Closing in favor of #2315 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hot fixes #2312
Everything explained in the issue. I intended to remove this part when removing Liquidity orders but, since we changed the way we check if the order price is out of market, this became more urgent.