Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for fee market price check #2324

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix bug for fee market price check #2324

merged 3 commits into from
Jan 24, 2024

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Jan 24, 2024 •
edited
Loading

Description

Quote sell amount and quote buy amount were substituted.

🤷

@sunce86 sunce86 added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Jan 24, 2024
@sunce86 sunce86 requested a review from a team as a code owner January 24, 2024 10:08
MartinquaXD
MartinquaXD approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this appears to be the only case where args were not correct but named args make sense to me anyway.

@sunce86 sunce86 merged commit afcc32f into main Jan 24, 2024
7 of 8 checks passed
@sunce86 sunce86 deleted the outside-market-price branch January 24, 2024 11:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

Assignees
No one assigned
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunce86 @MartinquaXD