Respect block gas limit in gasEstimate buffer #2353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looking at driver native solution submissions on Gnosis Chain, I notice that we sometimes fail due to:
This stems from the fact that we multiply the gasEstimate we receive during simulation by 2 (to account for inaccuracies, changes in the execution trace, refunds, etc.)
This PR makes is so that we upper bound this buffered estimate by the current block size.
Changes
infra::eth
to fetch the current gas limitThanks to @MartinquaXD great suggestion I moved the gas limit fetch into the
Fetch.sol
helper contract, which even allows this call to be infallible and synchronous 🙌 .How to test
Added a driver integration test