Reject orders with unknown preimages #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Feb 5, 2024
squadgazzz
approved these changes
Feb 5, 2024
fleupold
force-pushed
the
forbig_unknown_preimages
branch
from
37412e5 to
119a909
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have identified the remainder of legit use cases which don't provide us a valid pre image for their app data (we will assume an empty app data for those), we can now start rejecting any new integrations/orders that are trying to place orders with dummy or unknown
appData. This is important in order to have a reasonable assurance that we are aware in case a user places an order with important metadata (e.g. pre/post interactions) and can't later on be surprised by claims that we ignored part of the intent.Changes
How to test
Adjusted the existing e2e test
Related Issues
I could swear there was a cleanup issue somewhere but I cannot find it