Add cap for partner fee #2552
Merged
Add cap for partner fee #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
force-pushed
the
2541/add-cap-for-partner-fee
branch
from
74a03a2 to
878609e
Compare
MartinquaXD
reviewed
Mar 21, 2024
m-lord-renkse
force-pushed
the
2541/add-cap-for-partner-fee
branch
2 times, most recently
from
2ebafd3 to
15e801e
Compare
|
Issue for making the max partner fee cap configurable in the autopilot #2554 |
MartinquaXD
reviewed
Mar 21, 2024
m-lord-renkse
force-pushed
the
2541/add-cap-for-partner-fee
branch
5 times, most recently
from
d3c1a50 to
fb19923
Compare
m-lord-renkse
commented
Mar 21, 2024
m-lord-renkse
commented
Mar 21, 2024
m-lord-renkse
force-pushed
the
2541/add-cap-for-partner-fee
branch
from
fb19923 to
abdeda0
Compare
MartinquaXD
approved these changes
Mar 21, 2024
sunce86
approved these changes
Mar 21, 2024
| @@ -77,20 +82,22 @@ mod tests { | |||
|
|
|||
| // surplus fee policy without caps | |||
| let fee_policy_1 = domain::fee::Policy::Surplus { | |||
| factor: 0.1, | |||
| max_volume_factor: 1.0, | |||
| factor: FeeFactor::try_from(0.1).unwrap(), | |||
There was a problem hiding this comment.
nit: this should work like 0.1.try_into().unwrap() but feel free to ignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a maximum cap (0.01) for the partner fee in case it is 0.01 or above.
Changes
Factorto enforce the limits of the value [0, 1) and provides a function to cap the partner feeHow to test
Related Issues
Fixes #2541