Add request id header for rpc requests #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
rferrandop
force-pushed
the
rpc-request-id-header
branch
from
6bb8ded to
8741c6d
Compare
MartinquaXD
approved these changes
Apr 18, 2024
m-lord-renkse
approved these changes
Apr 18, 2024
squadgazzz
approved these changes
Apr 18, 2024
rferrandop
force-pushed
the
rpc-request-id-header
branch
from
8741c6d to
cfbec7a
Compare
|
Hi, I fixed the code formatting. Now the lint workflow should be working OK. |
Yeah, unfortunately these tests always fail for external contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a request id header for the RPC requests.
Changes
This PR adds the following request HTTP headers on RPC requests:
X-RPC-Request-Id- The unique ID of the RPC request.X-Request-Id- The top level request id passed as a request header for the RPC request generated.How to test
I couldn't find a suitable way to test this. Maybe, it would be useful to create tests for the RPC request execution and assert that those headers are been sending.
Related Issues
Fixes #2519