-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store settlement execution events #3289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable). Caused by: |
MartinquaXD
reviewed
Feb 24, 2025
MartinquaXD
reviewed
Feb 24, 2025
MartinquaXD
approved these changes
Feb 24, 2025
m-lord-renkse
approved these changes
Feb 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to improve the experience of oncall investigation related to MEVBlocker submissions and other settlement tx failures, a suggestion is to implement a CI job that will be able to collect auction execution stats, such as settlement execution start/end timestamps/blocks, addresses of the winning solvers, and a result explaining the outcome. This data is expected to be merged with onchain data such as tx hashes, block number attempts and builder addresses. That should save a lot of time on tx expiration/revert event investigations.
Changes
(auction_id, solver)
is used since each auction might have multiple winners(leading to multiple settlement txs).How to test
New DB tests.