Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store settlement execution events #3289

Merged
merged 20 commits into from
Feb 24, 2025
Merged

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Feb 21, 2025

Description

In order to improve the experience of oncall investigation related to MEVBlocker submissions and other settlement tx failures, a suggestion is to implement a CI job that will be able to collect auction execution stats, such as settlement execution start/end timestamps/blocks, addresses of the winning solvers, and a result explaining the outcome. This data is expected to be merged with onchain data such as tx hashes, block number attempts and builder addresses. That should save a lot of time on tx expiration/revert event investigations.

Changes

  • A new DB table where each row represents the minimum required data for each settlement.
  • Each row is populated in 2 steps: when the settlement execution is just started and then updates the existing row with the remaining data when it finishes.
  • A composite PK (auction_id, solver) is used since each auction might have multiple winners(leading to multiple settlement txs).
  • All the errors related to the execution stats storing are just logged since they should not block the runloop.

How to test

New DB tests.

Copy link

Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
If new tables were added, update the tables list.


Caused by:

@squadgazzz squadgazzz marked this pull request as ready for review February 21, 2025 12:52
@squadgazzz squadgazzz requested a review from a team as a code owner February 21, 2025 12:52
@squadgazzz squadgazzz added blocked This issue is blocked by some other work and removed blocked This issue is blocked by some other work labels Feb 24, 2025
@squadgazzz squadgazzz merged commit 0785e2f into main Feb 24, 2025
11 checks passed
@squadgazzz squadgazzz deleted the settlement-execution-events branch February 24, 2025 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants