Debugging improvements #3301
Open
Debugging improvements #3301
+69
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
reviewed
Feb 28, 2025
| tracing::warn!(?err, "failed to solve auction"); | ||
| tracing::debug!(?err, "failed to solve auction"); |
There was a problem hiding this comment.
Why not at least info here?
| tracing::warn!(?order, ?err, "failed to quote order"); | ||
| tracing::debug!(?order, ?err, "failed to quote order"); |
Comment on lines
-59
to
+55
| tracing::warn!("bad token detection for {:?} returned {:?}", token, quality); | ||
| tracing::debug!(?token, ?quality, "bad token detected"); |
There was a problem hiding this comment.
How else can we detect that the token was marked as bad?
mstrug
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to improve the usefulness of our logs a bit.
Changes
warnintodebuglogs since they usually don't indicate a real problemdebugintoinfologs to starting making the querylog: "info"return a good high level overview of each componentHow to test
mostly check logs when running the e2e tests