Bump gas price based on elapsed blocks for cancelling #3302
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
3shv
force-pushed
the
bumpGasFeeOnResubmit
branch
from
1c8e5b9 to
1613373
Compare
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Thanks for your contribution.
There are 2 bigger remarks here:
- submission logic can be quite finicky and complex so I'd like to only add the complexity where it's necessary. This PR focuses on the
refundercomponent which doesn't really struggle with cancellations so I'd prefer to not overcomplicate things unnecessarily. - A similar reasoning applies to the component the issue was about (
driver) so the change would be ideally less involved than this. It seems in the respective driver code this should be easier, since it can be solved with the introduction of one new local variable.
3shv
changed the title
|
Thanks for your review. I updated only the mempool.rs code now. Not sure where the tests should go.. |
crates/driver/src/domain/mempools.rs
Outdated
| ) -> Result<TxId, Error> { | ||
| let gas_price_bump_factor = GAS_PRICE_BUMP.powf(blocks_elapsed.max(1) as f64); |
There was a problem hiding this comment.
According to the issue #3241 description I think we need to just multiply the GAS_PRICE_BUMP by blocks_elapsed.
There was a problem hiding this comment.
@3shv your original version was actually correct (with the exception of using .powf() instead of powi()). Perhaps the issue was worded unfortunately.
The reason is that according to EIP-1559 the base fee can increase at most 12.5% from block n to n+1. So if we want to get the highest possible gas price after 3 blocks we would compute:
originalGasPrice * 1.125 * 1.125 * 1.125 or originalGasPrice * 1.125.powi(3).
There was a problem hiding this comment.
oh, that's interesting.
Thanks for the clarification. Learning new stuff everyday 😇
@squadgazzz I haven't checked carefully. But when I took a quick look, I couldn't find anything different in BASE chain. Please correct me if I'm mistaken. |
Co-authored-by: ilya <squad.gazzz@gmail.com>
Related to issue #3241