Multi flashloan support #3310
Merged
Multi flashloan support #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
approved these changes
Mar 6, 2025
squadgazzz
approved these changes
Mar 6, 2025
m-lord-renkse
approved these changes
Mar 6, 2025
MartinquaXD
force-pushed
the
multi-flashloan-encoding
branch
from
69976ac to
e797f54
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cowprotocol/flash-loan-wrapper-solver#9 updated the flashloan contracts to support multiple loans in a single settlement. Based on the included e2e test I updated the driver's encoding logic. Which contracts needs to get approved and where to move the funds remained unchanged. The only real difference is that the router is now always the target of the call and we pass details of each loan it should take out into it's function call together with the underlying
settle()call.Changes
How to test
so far I only updated the existing e2e test that takes out a single loan which is good enough for now
in a follow up PR we should add another e2e test that takes out 2 flashloans