Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for additional Tip #3311

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Fix bug for additional Tip #3311

merged 3 commits into from
Mar 6, 2025

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Mar 6, 2025

Description

I've noticed that non-colocated drivers almost always have tip = 1 gwei, even in volatile periods when base fee raises significantly.

The reason is, our first choice gas price estimator almost always returns tip < 1 gwei, so the self.min_priority_fee is always used as a tip and it's fixed. (The reason why gas price estimator always return tip <1 gwei will be analyzed independently of this fix, but one of the reasons can be: using default inclusion time of 30s always, estimating gas price at the SOLVE time instead of SETTLE time etc, or just not working properly).

This PR makes the tip always dependable of additionalTip config that is used by infra to additionally tweak gas price estimations if needed.

Changes

  • Additional tip is always added to final estimated tip.

How to test

Will try it out on staging.

@sunce86 sunce86 self-assigned this Mar 6, 2025
@sunce86 sunce86 requested a review from a team as a code owner March 6, 2025 09:26
Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, that looks reasonable. Can't come up with any pitfalls atm.

Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me but we might as well clean up a tiny bit of tech debt here.

@sunce86 sunce86 enabled auto-merge (squash) March 6, 2025 14:24
@sunce86 sunce86 added the oncall Issue/PR for consideration during oncall rotation label Mar 6, 2025
@sunce86 sunce86 merged commit 7bb3594 into main Mar 6, 2025
11 checks passed
@sunce86 sunce86 deleted the adjust-gas-price-additional-tip branch March 6, 2025 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
oncall Issue/PR for consideration during oncall rotation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants