Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that non-colocated drivers almost always have
tip
= 1 gwei, even in volatile periods when base fee raises significantly.The reason is, our first choice gas price estimator almost always returns tip < 1 gwei, so the
self.min_priority_fee
is always used as a tip and it's fixed. (The reason why gas price estimator always return tip <1 gwei will be analyzed independently of this fix, but one of the reasons can be: using default inclusion time of 30s always, estimating gas price at the SOLVE time instead of SETTLE time etc, or just not working properly).This PR makes the tip always dependable of
additionalTip
config that is used by infra to additionally tweak gas price estimations if needed.Changes
How to test
Will try it out on staging.