Implement the Component::link_requires
#116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/implement-link-requires
branch
2 times, most recently
from
f972f0b to
c0680e1
Compare
This just loads the link_requires, but doesn't do anything with it.
dcbaker
force-pushed
the
submit/implement-link-requires
branch
from
c0680e1 to
33ddd1b
Compare
We have to track whether a component is a link only component, and the only add the link flags.
dcbaker
force-pushed
the
submit/implement-link-requires
branch
from
33ddd1b to
36e859d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted to draft as I have come up with some more corner cases to test.I've resolved a bunch of corner cases, hopefully this is ready for review.