Require "prefix", allow absolute prefixes #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a semi-optional `prefix` attribute which can be used to specify an absolute prefix (for non-relocatable packages). Require that exactly one of `cps_path` or the new `prefix` is supplied. Improve documentation on how to determine the prefix from `cps_path`, and drop no-longer-needed guessing mechanisms. Remove "install" from "package [install] prefix", as packages aren't necessarily "installed". This is slightly more complicated in some ways, but does enforce that the CPS file itself always provides a substitution for `@prefix@`, which allows for some other simplifications. Note that, despite the seemingly minimal change to the schema, this is in some respects a significant breaking change in that something formerly optional is now required.
bretbrownjr
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a semi-optional
prefixattribute which can be used to specify an absolute prefix (for non-relocatable packages). Require that exactly one ofcps_pathor the newprefixis supplied. Improve documentation on how to determine the prefix fromcps_path, and drop no-longer-needed guessing mechanisms. Remove "install" from "package [install] prefix", as packages aren't necessarily "installed".This is slightly more complicated in some ways, but does enforce that the CPS file itself always provides a substitution for
@prefix@, which allows for some other simplifications. Note that, despite the seemingly minimal change to the schema, this is in some respects a significant breaking change in that something formerly optional is now required.Closes #84.