Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing and serializing CQL annotations in ELM XML and JSON (Kotlin feature branch) #1493

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

antvaset
Copy link
Contributor

What's included:

  • Remove JAXB from cql-to-elm
  • CQL annotations can be parsed and serialized in ELM XML and JSON
  • Narrative elements are handled as mixed content that can include text and nested Narrative elements

Copy link

Formatting check succeeded!

@antvaset antvaset marked this pull request as ready for review January 29, 2025 10:44
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 29.23077% with 46 lines in your changes missing coverage. Please review.

Project coverage is 68.13%. Comparing base (4479b47) to head (ca3fe1c).
Report is 1 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...ork/cql/elm/serializing/NarrativeJsonSerializer.kt 0.00% 43 Missing ⚠️
...cql/elm/serializing/xmlutil/ElmXmlLibraryCommon.kt 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1493      +/-   ##
====================================================
- Coverage             68.24%   68.13%   -0.11%     
+ Complexity             4785     4783       -2     
====================================================
  Files                   463      464       +1     
  Lines                 27484    27536      +52     
  Branches               5264     5266       +2     
====================================================
+ Hits                  18756    18762       +6     
- Misses                 6571     6618      +47     
+ Partials               2157     2156       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit dfa7f4a into feature-kotlin Jan 30, 2025
6 of 7 checks passed
@JPercival JPercival deleted the feature-kotlin-mixed-content-serialization branch January 30, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants