Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1497: Fixed Quantity sub-type casting behavior removing unit and com… #1498

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

brynrhodes
Copy link
Member

…parator elements from Quantity values.

Copy link

github-actions bot commented Feb 6, 2025

Formatting check succeeded!

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 39 lines in your changes missing coverage. Please review.

Project coverage is 64.40%. Comparing base (1c2eecb) to head (87a6573).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cqf/cql/engine/fhir/model/R5FhirModelResolver.java 0.00% 15 Missing ⚠️
.../cql/engine/fhir/model/Dstu2FhirModelResolver.java 0.00% 12 Missing ⚠️
.../cql/engine/fhir/model/Dstu3FhirModelResolver.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1498      +/-   ##
============================================
- Coverage     64.47%   64.40%   -0.07%     
- Complexity     1939     1940       +1     
============================================
  Files           494      494              
  Lines         28164    28218      +54     
  Branches       5593     5593              
============================================
+ Hits          18158    18175      +17     
- Misses         7731     7769      +38     
+ Partials       2275     2274       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit fdffefc into master Feb 11, 2025
6 of 7 checks passed
@JPercival JPercival deleted the fix-1497-quantity-sub-type-casting branch February 11, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants