Skip to content

Commit

Permalink
Fix BasicAuth bug in HttpConnectProxyOptions.ToInteropOptions() (temp…
Browse files Browse the repository at this point in the history
…oralio#334)

* Align all 'host:port' strings

* Use options.BasicAuth?.Password

* sync submodule
  • Loading branch information
adeal authored Aug 29, 2024
1 parent aa3edef commit 76e01fc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Temporalio/Bridge/EphemeralServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private unsafe EphemeralServer(
public override unsafe bool IsInvalid => ptr == null;

/// <summary>
/// Gets the target host:port of the server.
/// Gets the target <c>host:port</c> of the server.
/// </summary>
public string Target { get; private init; }

Expand Down
2 changes: 1 addition & 1 deletion src/Temporalio/Bridge/OptionsExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public static Interop.ClientHttpConnectProxyOptions ToInteropOptions(
{
target_host = scope.ByteArray(options.TargetHost),
username = scope.ByteArray(options.BasicAuth?.Username),
password = scope.ByteArray(options.BasicAuth?.Username),
password = scope.ByteArray(options.BasicAuth?.Password),
};
}

Expand Down
4 changes: 2 additions & 2 deletions src/Temporalio/Client/HttpConnectProxyOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ public HttpConnectProxyOptions()
/// <summary>
/// Initializes a new instance of the <see cref="HttpConnectProxyOptions"/> class.
/// </summary>
/// <param name="targetHost">A 'host:port' string representing the target to proxy through.</param>
/// <param name="targetHost">A <c>host:port</c> string representing the target to proxy through.</param>
public HttpConnectProxyOptions(string targetHost) => TargetHost = targetHost;

/// <summary>
/// Gets or sets the target host to proxy through as a host:port string.
/// Gets or sets the target host to proxy through as a <c>host:port</c> string.
/// </summary>
/// <remarks>
/// This is required for all proxy options.
Expand Down

0 comments on commit 76e01fc

Please sign in to comment.