Dzmitryi Basau #281
Open
Dzmitryi Basau #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2025 16:31
Updated RateLimiter.Tests.csproj to include Moq for mocking in tests. Significantly refactored RateLimiterTest.cs by replacing the single RateLimiterTest class with multiple test classes: FixedWindowRuleTests, SlidingWindowRuleTests, RegionalRuleTests, RateLimiterTests, and ConcurrencyTests. Each class contains multiple test methods. Updated RateLimiter.csproj to include Microsoft.Extensions.Logging for logging capabilities. Added RateLimiter.cs with the following: - IRateLimitRule interface with IsAllowed and Cleanup methods. - FixedWindowRule class implementing IRateLimitRule using a fixed window algorithm. - SlidingWindowRule class implementing IRateLimitRule using a sliding window algorithm. - RegionalRule class implementing IRateLimitRule applying rules based on client's region. - RateLimiter class managing multiple rate limiting rules and logging blocked requests.
Refactored the `IRateLimitRule`, `FixedWindowRule`, `SlidingWindowRule`, and `RegionalRule` classes into their own files within the `RateLimiter.Rules` namespace to improve code organization and modularity. Updated `RateLimiterTest.cs` and `RateLimiter.cs` to reflect these changes. Added additional region checks for "ASIA" and a default "GLOBAL" region in the `RegionalRule` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate-limiting implementation.