ci: add MIRI_LEAK_CHECK=1 on ci

crossbeam-rs · Jan 26, 2025 · 2de82b8 · 2de82b8
1 parent 77f38c2
commit 2de82b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/ci/miri.sh b/ci/miri.sh
@@ -15,10 +15,13 @@ export MIRIFLAGS="${MIRIFLAGS:-} -Zmiri-strict-provenance -Zmiri-symbolic-alignm
 
 case "${group}" in
     channel)
+        # -Zmiri-ignore-leaks is needed because we use detached threads in tests in tests/array.rs: panic_on_drop
         MIRI_LEAK_CHECK='1' \
+        MIRIFLAGS="${MIRIFLAGS} -Zmiri-ignore-leaks" \
             cargo miri test --all-features \
             -p crossbeam-channel 2>&1 | ts -i '%.s  '
         # -Zmiri-ignore-leaks is needed because we use detached threads in tests in tests/golang.rs: https://github.com/rust-lang/miri/issues/1371
+        MIRI_LEAK_CHECK='1' \
         MIRIFLAGS="${MIRIFLAGS} -Zmiri-ignore-leaks" \
             cargo miri test --all-features \
             -p crossbeam-channel --test golang 2>&1 | ts -i '%.s  '

diff --git a/crossbeam-channel/tests/array.rs b/crossbeam-channel/tests/array.rs
@@ -690,6 +690,8 @@ fn channel_through_channel() {
     .unwrap();
 }
 
+// On the current implementation, panic on drop will cause memory leaks
+#[cfg_attr(crossbeam_sanitize, ignore)]
 #[test]
 fn panic_on_drop() {
     struct Msg1<'a>(&'a mut bool);