ci: drop linux/arm/v7 from the platforms for building container-images #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
Rakshith-R and
yati1998
|
LGTM! kubernetes-csi-addons/docs/ci.md Line 18 in f037599 |
Madhu-1
previously approved these changes
Nov 28, 2024
mergify
bot
dismissed
Madhu-1’s stale review
Pull request has been modified.
Done! |
Madhu-1
reviewed
Nov 28, 2024
There is not need for `secrets.BUILD_PLATFORMS`, as the platforms are not confidential. Instead a variable has been created in the GitHub repository settings for it now. The `secrets.BUILD_PLATFORMS` includes linux/arm/v7, which is a slow and phased out architecture. All reasonable ARM platforms are linux/arm64 now. Dropping the linux/arm/v7 platform makes building the container images much faster. Closes: csi-addons#719 Signed-off-by: Niels de Vos <ndevos@ibm.com>
Madhu-1
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not need for
secrets.BUILD_PLATFORMS, as the platforms arenot confidential. Instead a variable has been created in the GitHub
repository settings for it now.
The
secrets.BUILD_PLATFORMSincludes linux/arm/v7, which is a slow andphased out architecture. All reasonable ARM platforms are linux/arm64
now. Dropping the linux/arm/v7 platform makes building the container
images much faster.
Closes: #719