Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require values when posting news #149

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Require values when posting news #149

merged 1 commit into from
Jan 30, 2025

Conversation

GAsplund
Copy link
Member

Key features

  • Wrap the page for publishing news in a form, making sure that values are filled in properly before posting
  • Default the "publish as" value to nothing
  • Use more explicit "no group" instead of "myself" for choosing which group to publish as

Known issues

Shouldn't be any.

@GAsplund GAsplund requested a review from simon-wg January 30, 2025 09:34
simon-wg
simon-wg approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@simon-wg simon-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, unable to try it locally since I'm struggling with getting auth for the dev env but I'm assuming you have tried it.

@GAsplund GAsplund merged commit 8abf139 into main Jan 30, 2025
5 checks passed
@GAsplund GAsplund deleted the feature/news-form-validation branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-wg simon-wg simon-wg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAsplund @simon-wg