Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pre-commit (for linting) to test dependencies. #671

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

alxmrs
Copy link
Contributor

@alxmrs alxmrs commented Jan 15, 2025

Fixes #668.

@tomwhite
Copy link
Member

I'm not sure we need to add pre-commit for testing do we? Perhaps we could use https://pre-commit.ci/, or maybe we could add another GH action (or extend/modify the mypy one). Might be worth seeing what other projects do.

@alxmrs
Copy link
Contributor Author

alxmrs commented Jan 15, 2025

Hmm. Maybe a better fit would be to add an extra just for linting? Then, when we eventually add this to CI, the lint script can run in it's own check? WDYT?

@tomwhite
Copy link
Member

If possible, I'd copy what another project is doing rather than coming up with a new way of doing things.

A quick look shows:

@tomwhite tomwhite merged commit afd519a into cubed-dev:main Feb 11, 2025
17 of 18 checks passed
@tomwhite
Copy link
Member

Thanks @alxmrs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linting to CI
2 participants