-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: universal Modal component #666
Conversation
@orangelckc 感谢你的贡献,麻烦拉取最新代码,解决下现有冲突后提交,感谢! |
@yaolifeng0629 已处理冲突,与当前主分支同步。 目前存在的问题:当前题目下,设置更改后,不能立即生效,但是进入下一题是会生效的。 可能需要核心团队重构当前store的使用方式后处理。 |
另外可以优化的一个点,建议将Modal全部更新为函数式动态挂载,目前会在页面中同时存在多个modal,可能会出现渲染层级问题 |
感谢!
下一步建议: 先把这个 pr 改成只提交 重构 dialog 的功能 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
重构了设置页面的响应式布局,方便之后将部分设置项抽离至游戏页面

游戏页面的设置弹窗计划参考如下: