Added more tests

docs/user/README.md

@@ -717,6 +717,16 @@ eg:
 - `join air`: Join the line with the token containing the letter 'a' with its next line.
 - `join block air`: Joines all lines in the paragraph with the token containing the letter 'a' together into a single line.
 
+### Break
+
+Break line in two.
+
+- `"break <TARGET>"`
+
+eg:
+
+- `break air`: Break the line with the token containing the letter 'a'. 'a' is now the first token on the new line.
+
 ## Paired delimiters
 
 | Default spoken form | Delimiter name        | Symbol inserted before target | Symbol inserted after target | Is wrapper? | Is selectable? |

packages/cursorless-engine/src/actions/BreakLine.ts

@@ -1,4 +1,4 @@
-import { FlashStyle, Range, TextEditor } from "@cursorless/common";
+import { FlashStyle, Position, Range, TextEditor } from "@cursorless/common";
 import { flatten, zip } from "lodash";
 import type { RangeUpdater } from "../core/updateSelections/RangeUpdater";
 import { performEditsAndUpdateRanges } from "../core/updateSelections/updateSelections";
@@ -50,10 +50,21 @@ function getEdits(editor: TextEditor, contentRanges: Range[]): Edit[] {
       0,
       line.firstNonWhitespaceCharacterIndex,
     );
+    const characterTrailingWhitespace = line.text
+      .slice(0, position.character)
+      .search(/\s+$/);
+    const replacementRange =
+      characterTrailingWhitespace > -1
+        ? new Range(
+            new Position(line.lineNumber, characterTrailingWhitespace),
+            position,
+          )
+        : position.toEmptyRange();
 
     edits.push({
-      range: position.toEmptyRange(),
+      range: replacementRange,
       text: "\n" + indentation,
+      isReplace: !replacementRange.isEmpty,
     });
   }
 

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/breakBat.yml

@@ -19,7 +19,7 @@ initialState:
       end: {line: 0, character: 7}
 finalState:
   documentContents: |-
-    aaa 
+    aaa
     bbb ccc
   selections:
     - anchor: {line: 0, character: 0}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/breakCommentSit.yml

@@ -29,7 +29,7 @@ finalState:
   documentContents: |-
     [
       0,
-      1, 
+      1,
       // interesting
       2
     ]

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/breakJustThis.yml

@@ -0,0 +1,32 @@
+languageId: plaintext
+command:
+  version: 6
+  spokenForm: break just this
+  action:
+    name: breakLine
+    target:
+      type: primitive
+      mark: {type: cursor}
+      modifiers:
+        - {type: toRawSelection}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: "ab "
+  selections:
+    - anchor: {line: 0, character: 1}
+      active: {line: 0, character: 1}
+  marks: {}
+finalState:
+  documentContents: |-
+    a
+    b 
+  selections:
+    - anchor: {line: 1, character: 0}
+      active: {line: 1, character: 0}
+  thatMark:
+    - type: UntypedTarget
+      contentRange:
+        start: {line: 1, character: 0}
+        end: {line: 1, character: 0}
+      isReversed: false
+      hasExplicitRange: true

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/breakJustThis2.yml

@@ -0,0 +1,32 @@
+languageId: plaintext
+command:
+  version: 6
+  spokenForm: break just this
+  action:
+    name: breakLine
+    target:
+      type: primitive
+      mark: {type: cursor}
+      modifiers:
+        - {type: toRawSelection}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: "    ab "
+  selections:
+    - anchor: {line: 0, character: 5}
+      active: {line: 0, character: 5}
+  marks: {}
+finalState:
+  documentContents: |2-
+        a
+        b 
+  selections:
+    - anchor: {line: 1, character: 4}
+      active: {line: 1, character: 4}
+  thatMark:
+    - type: UntypedTarget
+      contentRange:
+        start: {line: 1, character: 4}
+        end: {line: 1, character: 4}
+      isReversed: false
+      hasExplicitRange: true