Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change eslint naming convention config for quoted keys #2132

Closed
AndreasArvidsson opened this issue Dec 14, 2023 · 0 comments · Fixed by #2456
Closed

Change eslint naming convention config for quoted keys #2132

AndreasArvidsson opened this issue Dec 14, 2023 · 0 comments · Fixed by #2456
Labels
code quality Improvements to code quality

Comments

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Dec 14, 2023 •
edited
Loading

Use:
https://typescript-eslint.io/rules/naming-convention/#ignore-properties-that-require-quotes

Remove file level disabled lint rule:

cursorless/packages/common/src/scopeSupportFacets/javascript.ts

Line 1 in 5e1abf8

/* eslint-disable @typescript-eslint/naming-convention */

Originally posted by @pokey in #2102 (comment)
@AndreasArvidsson AndreasArvidsson mentioned this issue Dec 14, 2023
Merged
1 task
@auscompgeek auscompgeek added code quality Improvements to code quality labels Jun 10, 2024
@auscompgeek auscompgeek changed the title Change esconfig naming convention for quoted keys Change eslint naming convention config for quoted keys Jun 10, 2024
pokey added a commit that referenced this issue Jun 28, 2024
@pokey
Allow . in literal property names for use with facets
b1d294d 
- Fixes #2132
@pokey pokey mentioned this issue Jun 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 29, 2024
@pokey
Allow . in literal property names for use with facets (#2456)
4e647b3 
- Fixes #2132



## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvements to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow . in literal property names for use with facets cursorless-dev/cursorless
2 participants
@auscompgeek @AndreasArvidsson