Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more scope support facets #2102

Merged
merged 49 commits into from
Dec 14, 2023
Merged

Added more scope support facets #2102

merged 49 commits into from
Dec 14, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 7, 2023 •
edited
Loading

This pull request has these goals:

  1. To flesh out the available facets and their definitions
  2. To provide one example scope fixture of each facet
  3. Update the domain of for each loops name/value/type
  4. Update domain of iteration scope for formal arguments

Once the above is done I'm going to do the bulk fixture recorder we talked about to fill in the other languages.

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review December 7, 2023 08:29
@AndreasArvidsson AndreasArvidsson mentioned this pull request Dec 8, 2023
Closed
pokey
pokey reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually pretty comprehensive! I added a few more. In a follow-up, we should

  • add more iteration scopes for name / value / type
  • add named.method
  • add some more "statement" scope facets

packages/common/src/scopeSupportFacets/html.ts Show resolved Hide resolved
packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts Outdated Show resolved Hide resolved
packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts Outdated Show resolved Hide resolved
packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts Show resolved Hide resolved
packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts Outdated Show resolved Hide resolved
packages/cursorless-vscode-e2e/src/suite/fixtures/scopes/javascript/name.field.scope Show resolved Hide resolved
packages/cursorless-vscode-e2e/src/suite/fixtures/scopes/javascript/value.field.scope Outdated Show resolved Hide resolved
queries/javascript.core.scm Outdated Show resolved Hide resolved
queries/javascript.core.scm Outdated Show resolved Hide resolved
queries/javascript.core.scm Outdated Show resolved Hide resolved
AndreasArvidsson and others added 11 commits December 11, 2023 19:13
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
996e23f 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
171ccfd 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
3703c3b 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
10ef954 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson
Merge branch 'main' into scopes
b84d97a
@AndreasArvidsson
cleaned up leading trailing
2163c20
@AndreasArvidsson
Updated field removal
ae9e7a4
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
50aa135 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
7973111 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson @pokey
Update packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts
4bbaf0a 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson
use legacy
ef3b29b
@pokey pokey mentioned this pull request Dec 12, 2023
Closed
1 task
pokey
pokey reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops looks like I forgot to submit these comments

packages/common/src/scopeSupportFacets/typescript.ts Show resolved Hide resolved
queries/javascript.core.scm Outdated Show resolved Hide resolved
packages/common/src/scopeSupportFacets/html.ts Show resolved Hide resolved
packages/common/src/scopeSupportFacets/scopeSupportFacetInfos.ts Outdated Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson mentioned this pull request Dec 14, 2023
Closed
This was referenced Dec 14, 2023
Closed
Closed
pokey
pokey approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pokey pokey added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 15bfde5 Dec 14, 2023
13 checks passed
@pokey pokey deleted the scopes branch December 14, 2023 17:53
@pokey pokey mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josharian josharian josharian left review comments

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change domain of iteration scope of "arg" to include entire function
3 participants
@AndreasArvidsson @josharian @pokey