Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show leading / trailing / removal / insertion delimiter if equal to token semantics in scope fixtures #2140

Closed
pokey opened this issue Dec 14, 2023 · 1 comment
Labels
code quality Improvements to code quality to discuss Plan to discuss at meet-up

Comments

@pokey
Copy link
Member

pokey commented Dec 14, 2023

I believe we'd just expand to containing token if scope type isn't token, and then check that its content range / leading / trailing / insertion delimiter / removal are equal the token scope. If so, we drop leading / trailing / insertion delimiter / removal. I don't think we have a way to expand to containing scope via generic scope provider, but trivial to add and prob useful for future visualizations, eg show scope containing cursor

See #2102 (comment) for more

@pokey pokey added code quality Improvements to code quality to discuss Plan to discuss at meet-up labels Dec 14, 2023
@pokey
Copy link
Member Author

pokey commented Jan 7, 2024

update from meet-up:

@pokey pokey closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality to discuss Plan to discuss at meet-up
Projects
None yet
Development

No branches or pull requests

1 participant