Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show lines in our facet tests that are outside of the range #2164

Closed
pokey opened this issue Jan 7, 2024 · 0 comments · Fixed by #2207
Closed

Don't show lines in our facet tests that are outside of the range #2164

pokey opened this issue Jan 7, 2024 · 0 comments · Fixed by #2207

Comments

@pokey
Copy link
Member

pokey commented Jan 7, 2024 •
edited
Loading

See #2102 (comment) for more, but basically, instead of:

aaa(bbb);
const ccc = aaa(bbb);
ccc + aaa(bbb);
ccc(aaa(bbb));
---

[#1 Content] =
[#1 Removal] = 0:0-0:8
0| aaa(bbb);
  >--------<
1| const ccc = aaa(bbb);
2| ccc + aaa(bbb);
3| ccc(aaa(bbb));

we would do

aaa(bbb);
const ccc = aaa(bbb);
ccc + aaa(bbb);
ccc(aaa(bbb));
---

[#1 Content] =
[#1 Removal] = 0:0-0:8
0| aaa(bbb);
  >--------<
@pokey pokey mentioned this issue Jan 7, 2024
Closed
@pokey pokey mentioned this issue Jan 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2024
@pokey
Don't show lines in our facet tests that are outside of the range (#2207
d228144 
)

Fixes #2164

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
pokey added a commit that referenced this issue Jan 31, 2024
@pokey
Don't show lines in our facet tests that are outside of the range (#2207
3be886c 
)

Fixes #2164

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet
@AndreasArvidsson AndreasArvidsson mentioned this issue Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show lines in our facet tests that are outside of the range cursorless-dev/cursorless
1 participant
@pokey