Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .only to reenable tests #2104

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove .only to reenable tests #2104

merged 1 commit into from
Dec 7, 2023

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

auscompgeek
auscompgeek approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. We should find a lint rule to prevent this sort of thing being merged. I know eslint-plugin-jest has a similar rule.

@pokey pokey added this pull request to the merge queue Dec 7, 2023
@pokey
Copy link
Member

pokey commented Dec 7, 2023

i was thinking #2105 but yeah if there's something out of the box

@pokey
Copy link
Member

pokey commented Dec 7, 2023

found a rule; updated issue. good call @auscompgeek

Merged via the queue into main with commit a9cc79f Dec 7, 2023
13 checks passed
@pokey pokey deleted the enableTests branch December 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auscompgeek auscompgeek auscompgeek approved these changes

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreasArvidsson @pokey @auscompgeek