Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reset stored targets when running tests #2109

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

AndreasArvidsson
Copy link
Member

Stored targets were not updated if the fixture contained none. This means that stored targets from previous fixture was still active. In one case it made a instance tests incorrectly use the from target set by the previous recorded test and the instance test failed as a result.

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey enabled auto-merge December 8, 2023 08:44
@pokey pokey added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 811447f Dec 8, 2023
13 checks passed
@pokey pokey deleted the recordedwMarks branch December 8, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants