Added function scope test to python #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
approved these changes
May 12, 2024
|
Maybe? |
|
Why wouldn't we? |
|
I was just thinking that our tests might test different syntax patterns, but I'm not against removing them. |
|
I think the idea should be for our scope tests to cover what our recorded tests used to cover. Maybe we should migrate one scope-language pair at a time? Ie for this PR we look at what recorded tests we have for Python lambda and function, add scope tests that are at least as comprehensive, and remove the recorded tests? It's a bit more work, but would be nice to get our test suite a bit more principled |
|
Sounds good. Tests updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist