Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clojure scope migration #2337

Merged
merged 2 commits into from
May 30, 2024
Merged

Clojure scope migration #2337

merged 2 commits into from
May 30, 2024

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner May 17, 2024 13:32
pokey
pokey reviewed May 17, 2024
View reviewed changes
queries/clojure.scm Outdated
;; A list is either a vector literal or a quoted list literal
[
(vec_lit)
(quoting_lit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seem to have dropped the .list_lit child here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@auscompgeek auscompgeek added the scope-migration Migrating scopes to next-gen scope implementation label May 18, 2024
@AndreasArvidsson AndreasArvidsson changed the title Migrate clojure scopes Clojure scopes migration May 23, 2024
@AndreasArvidsson AndreasArvidsson changed the title Clojure scopes migration Clojure scope migration May 23, 2024
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit e2ee82a May 30, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the clojure_migration branch May 30, 2024 14:19
@auscompgeek auscompgeek added the lang-lisp Lisp dialect grammar support label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-lisp Lisp dialect grammar support scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreasArvidsson @pokey @auscompgeek