-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css scope migration #2339
css scope migration #2339
Changes from 4 commits
bc9e661
b1bc38c
f8f987b
13d759c
56a1bf1
e4a89de
d377e30
9496ae0
3b6c780
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
a { color: red; } | ||
--- | ||
|
||
[#1 Range] = | ||
[#1 Domain] = 0:0-0:17 | ||
>-----------------< | ||
0| a { color: red; } | ||
|
||
|
||
[#2 Range] = | ||
[#2 Domain] = 0:3-0:16 | ||
>-------------< | ||
0| a { color: red; } |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/* hello */ | ||
--- | ||
|
||
[Range] = | ||
[Domain] = 0:0-0:11 | ||
>-----------< | ||
0| /* hello */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/* hello */ | ||
--- | ||
|
||
[Range] = | ||
[Domain] = 0:0-0:11 | ||
>-----------< | ||
0| /* hello */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
a { color: red; } | ||
--- | ||
|
||
[#1 Range] = | ||
[#1 Domain] = 0:0-0:17 | ||
>-----------------< | ||
0| a { color: red; } | ||
|
||
|
||
[#2 Range] = | ||
[#2 Domain] = 0:3-0:16 | ||
>-------------< | ||
0| a { color: red; } |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"imports": ["css"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/* hello */ | ||
--- | ||
|
||
[Range] = | ||
[Domain] = 0:0-0:11 | ||
>-----------< | ||
0| /* hello */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
a { color: red; } | ||
--- | ||
|
||
[#1 Range] = | ||
[#1 Domain] = 0:0-0:17 | ||
>-----------------< | ||
0| a { color: red; } | ||
|
||
|
||
[#2 Range] = | ||
[#2 Domain] = 0:3-0:16 | ||
>-------------< | ||
0| a { color: red; } |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,6 +124,21 @@ export const scopeSupportFacetInfos: Record< | |
description: "A named method declaration in a class", | ||
scopeType: "namedFunction", | ||
}, | ||
"namedFunction.method.iteration.class": { | ||
description: "Iteration scope for named functions: class bodies", | ||
scopeType: "namedFunction", | ||
isIteration: true, | ||
}, | ||
"namedFunction.iteration": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pokey There's no indicator in the name or description what this iteration scope should be. Shouldn't this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah so the issue is that we don't necessarily want the iteration scope for functions to always include blocks. For example, that's not what we do in typescript. I added this as a catch-all so that I could include blocks for css. Might be worth discussing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can us go ahead and merge this because we can always update later? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Slightly mixed feelings about merging in facet ids that we will want to change, as I think it could be a bit painful to rename them, especially as they get used more There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possibly. Should be punt on this then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. Would be good to get this PR in, but I think it's going to be easier to get this one right, as we use this facet for this PR. I'd be inclined to discuss Sunday There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On second thought, let's get this thing in. I filed #2375; let's discuss Sunday |
||
description: "Iteration scope for named functions", | ||
scopeType: "namedFunction", | ||
isIteration: true, | ||
}, | ||
"namedFunction.iteration.document": { | ||
description: "Iteration scope for named functions: the entire document", | ||
scopeType: "namedFunction", | ||
isIteration: true, | ||
}, | ||
anonymousFunction: { | ||
description: | ||
"An anonymous function, eg a lambda function, an arrow function, etc", | ||
|
@@ -133,6 +148,25 @@ export const scopeSupportFacetInfos: Record< | |
description: "The name of a function", | ||
scopeType: "functionName", | ||
}, | ||
"functionName.method": { | ||
description: "The name of a method in a class", | ||
scopeType: "functionName", | ||
}, | ||
"functionName.method.iteration.class": { | ||
description: "Iteration scope for function names: class bodies", | ||
scopeType: "functionName", | ||
isIteration: true, | ||
}, | ||
"functionName.iteration": { | ||
description: "Iteration scope for function names", | ||
scopeType: "functionName", | ||
isIteration: true, | ||
}, | ||
"functionName.iteration.document": { | ||
description: "Iteration scope for function names: the entire document", | ||
scopeType: "functionName", | ||
isIteration: true, | ||
}, | ||
|
||
functionCall: { | ||
description: "A function call", | ||
|
@@ -299,6 +333,17 @@ export const scopeSupportFacetInfos: Record< | |
scopeType: "name", | ||
isIteration: true, | ||
}, | ||
"name.iteration.block": { | ||
description: | ||
"Iteration scope for names: statement blocks (body of functions/if classes/for loops/etc).", | ||
scopeType: "name", | ||
isIteration: true, | ||
}, | ||
"name.iteration.document": { | ||
description: "Iteration scope for names: the entire document", | ||
scopeType: "name", | ||
isIteration: true, | ||
}, | ||
"key.attribute": { | ||
description: "Key (LHS) of an attribute eg in an xml element", | ||
scopeType: "collectionKey", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that this was missing inspired #2370, which also includes this file