Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate snippets follow up #2789

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Migrate snippets follow up #2789

merged 6 commits into from
Jan 30, 2025

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jan 29, 2025 •
edited
Loading

  1. Skip snippets with fields we cannot migrate instead of just discarding those fields
  2. Show a untitled markdown document with the migration results
  3. Use spoken forms/phrases from Talon

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner January 29, 2025 08:00
@AndreasArvidsson AndreasArvidsson mentioned this pull request Jan 29, 2025
Merged
2 tasks
@phillco phillco enabled auto-merge January 30, 2025 16:52
@phillco phillco added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 2c19566 Jan 30, 2025
15 checks passed
@phillco phillco deleted the migrateSnippetsV2 branch January 30, 2025 17:57
cursorless-bot pushed a commit that referenced this pull request Jan 30, 2025
@AndreasArvidsson @phillco
Migrate snippets follow up (#2789)
1d7c9bd 
1. Skip snippets with fields we cannot migrate instead of just
discarding those fields
2. Show a untitled markdown document with the migration results
3. Use spoken forms/phrases from Talon

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Phil Cohen <phillip@phillip.io>
@phillco phillco mentioned this pull request Feb 4, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillco phillco phillco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @phillco