Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test workflow for app_version variable #2795

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Update test workflow for app_version variable #2795

merged 2 commits into from
Jan 30, 2025

Conversation

AndreasArvidsson
Copy link
Member

vscode_version was renamed to app_version, but some of the if checks were not updated

Checklist

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner January 30, 2025 09:37
phillco
phillco approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes thx

@phillco phillco enabled auto-merge January 30, 2025 16:02
@phillco phillco added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 232c167 Jan 30, 2025
15 checks passed
@phillco phillco deleted the app_version branch January 30, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillco phillco phillco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @phillco