Actions: attempt to validate PR description tests #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
approved these changes
Feb 1, 2025
phillco
added a commit
that referenced
this pull request
Feb 1, 2025
We're now validating in #2810 that it is removed, so we should tell the person to remove it
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
A few follow up changes were required for this to work: ... Otherwise, if you pushed a change but did not edit the description or attributes of the pull request, the status would be missing on the most recent commit. Because it's a required status, it needs to be present on the latest commit before you can queue to merge. The synchronize event runs after new commits are pushed to the pull request branch. .. Otherwise the job wouldn't be retriggered after the change is added to the merge queue |
|
Tested with #2809 that it won't be queued to automatically merge until the check passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub includes the description comment when it formulates the commit message, which we don't want as it's pretty messy. We will ask users to remove the comment but we need to validate it before allowing merging.
Stolen from https://github.com/orgs/community/discussions/84771#discussioncomment-8039595.