Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cursorless formatter names to community #2819

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Migrate Cursorless formatter names to community #2819

merged 3 commits into from
Feb 4, 2025

Conversation

AndreasArvidsson
Copy link
Member

No description provided.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner February 4, 2025 19:39
phillco
phillco approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this?

packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved
packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved
@AndreasArvidsson @phillco
Apply suggestions from code review
54ea777 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@AndreasArvidsson
Copy link
Member Author

What do you think of this?

Looks good

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 8543660 Feb 4, 2025
16 checks passed
@AndreasArvidsson AndreasArvidsson deleted the migrationFormatters branch February 4, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillco phillco phillco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @phillco