Native support for non-core evaluation operators #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansjoergschurr
approved these changes
Jun 8, 2024
src/literal.cpp
Outdated
| case Kind::EVAL_GT: | ||
| switch (ka) | ||
| { | ||
| case Kind::NUMERAL:return Literal(args[0]->d_int>args[0]->d_int); |
There was a problem hiding this comment.
I think a line break here would improve readability.
user_manual.md
Outdated
| @@ -489,7 +494,21 @@ Core operators: | |||
| - If `t1` is a ground constant or variable, this returns the name of `t1`, i.e. the string corresponding to the symbol it was declared with. | |||
| - `(alf.var t1 t2)` | |||
| - If `t1` is a string value and `t2` is ground type, this returns the variable whose name is `t1` and whose type is `t2`. | |||
|
|
|||
| - `(alf.cmp t1 t2)` | |||
| - Equivalent to `(alf.is_neg (alf.add (alf.neg (alf.hash t1)) (alf.hash t2)))`. | |||
There was a problem hiding this comment.
I think it makes sense to state here that this defines an (arbitrary) total-order on terms. I guess it might not always correspond to what people expect (e.g. on strings it is not lexicographic order)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.