Export locales so consumers can set language without duplicating code #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyntler
requested changes
Jun 15, 2024
src/index.tsx
Outdated
| @@ -7,5 +7,5 @@ export default DocViewer; | |||
| export { DocViewerRenderers } from "./renderers"; | |||
| export * from "./models"; | |||
| export * from "./utils/fileLoaders"; | |||
| export { type AvailableLanguages } from "./i18n"; | |||
| export { type AvailableLanguages, locales } from "./i18n"; | |||
There was a problem hiding this comment.
Ok but with this, we export json files...
We should export smth like Object.keys() of this locales object.
There was a problem hiding this comment.
Point taken. I have refactored the PR accordingly.
cyntler
approved these changes
Jun 17, 2024
|
@smorton-planview Has been merged! Will be delivered with the next release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers that want to set DocViewer language to a valid value from
AvailableLanguagesare currently forced to recreate an array of locales to compare against sinceAvailableLanguagesis a union type and its values are compiled away and not available at run time.This change aims to export the locales so that consumers can avoid duplicating the locales within their code. The goal would be to use navigator.language.split('-')[0] to produce a valid
AvailableLanguages.