Fix flatten which-key--update advice for toggle functions. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass `flatten` parameter to `hercules-hide` in order to remove advice for `which-key--update` when flattened. Otherwise, which-key no longer pops-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
flattenparameter tohercules-hidein order to remove advice forwhich-key--updatewhen flattened. Otherwise, which-key no longer pops-up after certain events.For example, using the code from top of README for macrostep-mode being the
toggle-funsworks great.Except if hit
qin macrostep-mode, the map is toggled off when mode is quit. Then which-key no longer works, due to the override advice forwhich-key--updatenot being removed. By passing flatten param from hercules toggle, the hercules hide function removes advice.