atualizando queries para utilizar views #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joellensilva
commented
Jan 27, 2025
•
joellensilva
commented
- Foram criadas views materializadas com os dados de anos e meses inconsistentes
- Atualização para utilizá-las
- Utilizar um trigger baseado na inserção de dados poderia afetar significativamente o desempenho do banco, levando em conta que, em dias de coleta, podemos ter entre 100 a 800 atualizações nas tabelas num único dia, o que atualizaria as views na mesma frequência. Dessa forma, as views serão atualizadas após as coletas, quando já finalizadas as modificações no banco de todos os órgãos.
joellensilva
requested review from
talitalobo
and removed request for
fonluiz
JezzDiego
approved these changes
Jan 28, 2025
talitalobo
requested review from
fonluiz
and removed request for
talitalobo and
rdurl0
fonluiz
reviewed
Feb 3, 2025
Comment on lines
+145
to
+161
| WITH remuneracoes_inconsistentes AS ( | ||
| SELECT DISTINCT orgao, ano | ||
| FROM remuneracoes | ||
| WHERE inconsistente = TRUE | ||
| ) | ||
| SELECT distinct c.id_orgao, c.ano, | ||
| CASE | ||
| WHEN ri.orgao IS NOT NULL THEN TRUE | ||
| ELSE FALSE | ||
| END AS inconsistente | ||
| FROM coletas c | ||
| LEFT JOIN remuneracoes_inconsistentes ri | ||
| ON ri.orgao = c.id_orgao | ||
| AND ri.ano = c.ano | ||
| WHERE c.atual = true | ||
| AND (c.procinfo::text = 'null' OR c.procinfo IS NULL); |
There was a problem hiding this comment.
Essa view parece redundante já que vc pode obter o órgão e o ano a partir da outra view.
Comment on lines
+126
to
+143
| WITH remuneracoes_inconsistentes AS ( | ||
| SELECT DISTINCT orgao, ano, mes | ||
| FROM remuneracoes | ||
| WHERE inconsistente = TRUE | ||
| ) | ||
| SELECT c.id_orgao, c.ano, c.mes, | ||
| CASE | ||
| WHEN ri.orgao IS NOT NULL THEN TRUE | ||
| ELSE FALSE | ||
| END AS inconsistente | ||
| FROM coletas c | ||
| LEFT JOIN remuneracoes_inconsistentes ri | ||
| ON ri.orgao = c.id_orgao | ||
| AND ri.ano = c.ano | ||
| AND ri.mes = c.mes | ||
| WHERE c.atual = TRUE | ||
| AND (c.procinfo::text = 'null' OR c.procinfo IS NULL); |
There was a problem hiding this comment.
Como eu não sei qual a lógica que se espera dessa view eu só posso comentar sobre a sintaxe ou boas práticas em geral. O código está bem escrito dessa perspectiva.
Se esse join estiver demorando muito, considere criar um índice nas tabelas para otimizar o lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.