fix tests to account for runtime checking of interface implementation

Signed-off-by: Erik Sipsma <erik@sipsma.dev>
dagger · Dec 12, 2023 · 01b09ff · 01b09ff
1 parent 0da6393
commit 01b09ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/abstract_test.go b/abstract_test.go
@@ -424,7 +424,7 @@ func TestResolveTypeOnInterfaceYieldsUsefulError(t *testing.T) {
 	humanType = graphql.NewObject(graphql.ObjectConfig{
 		Name: "Human",
 		Fields: graphql.Fields{
-			"name": &graphql.Field{
+			"job": &graphql.Field{
 				Type: graphql.String,
 			},
 		},
@@ -507,7 +507,7 @@ func TestResolveTypeOnInterfaceYieldsUsefulError(t *testing.T) {
 		},
 		Errors: []gqlerrors.FormattedError{
 			{
-				Message: `Runtime Object type "Human" is not a possible type for "Pet".`,
+				Message: `"Pet" expects field "name" but "Human" does not provide it.`,
 				Locations: []location.SourceLocation{
 					{
 						Line:   2,

diff --git a/executor.go b/executor.go
@@ -794,6 +794,12 @@ func completeAbstractValue(eCtx *executionContext, returnType Abstract, fieldAST
 	}
 	if unionReturnType, ok := returnType.(*Union); ok && unionReturnType.ResolveType != nil {
 		runtimeType = unionReturnType.ResolveType(resolveTypeParams)
+		if !eCtx.Schema.IsPossibleType(returnType, runtimeType) {
+			panic(gqlerrors.NewFormattedError(
+				fmt.Sprintf(`Runtime Object type "%v" is not a possible type `+
+					`for "%v".`, runtimeType, returnType),
+			))
+		}
 	} else if interfaceReturnType, ok := returnType.(*Interface); ok && interfaceReturnType.ResolveType != nil {
 		runtimeType = interfaceReturnType.ResolveType(resolveTypeParams)
 		// verify the object matches the interface