Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating num_positive_words_this_iter once you get random word #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updating num_positive_words_this_iter once you get random word #3

wants to merge 1 commit into from

Conversation

kanihal
Copy link
Contributor

@kanihal kanihal commented Oct 16, 2017 •
edited
Loading

updating num_positive_words_this_iter once you get random word

octavian-ganea
octavian-ganea approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@octavian-ganea octavian-ganea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very essential, but might introduce bugs, so it's better to fix it. Anyway, this branch will only be reached for very rare entities without any canonical page content and in which all title words are UNK, which should happen very rarely, if never.

@kanihal
Copy link
Contributor Author

kanihal commented Oct 17, 2017 •
edited
Loading

I'm following the exact instruction that is mentioned in the readme of this repo without any modification in the dataset whatsoever, The branch is getting reached quite a lot of times and used to crash there. That's how I found out the variable needs to be updated.

The script data_gen/gen_p_e_m/gen_p_e_m_from_yago.lua used to crash because of % issue not handled properly in LUA52, hence I made another pull request #4 . Does this modification have any effect on control reaching to the branch above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavian-ganea octavian-ganea octavian-ganea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanihal @octavian-ganea