Merge branch 'A-CheckStyle' into master

build.gradle

@@ -38,7 +38,7 @@ shadowJar {
 }
 
 checkstyle {
-    toolVersion = '8.23'
+    toolVersion = '8.32'
 }
 
 run{

config/checkstyle/suppressions.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+    "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  <suppress checks="JavadocType" files=".*Test\.java"/>
+  <suppress checks="MissingJavadocMethodCheck" files=".*Test\.java"/>
+</suppressions>

src/main/java/duke/exceptions/DukeException.java

@@ -3,7 +3,7 @@
 /**
  * Custom Exception for Duke.
  */
-public class DukeException extends Exception{
+public class DukeException extends Exception {
 
     public DukeException(String errorMessage) {
         super(errorMessage);

src/main/java/duke/logic/commands/AddCommand.java

@@ -14,14 +14,14 @@
 /**
  * Handles 'deadline', 'event' and 'todo' command input by user.
  */
-public class AddCommand extends Command{
+public class AddCommand extends Command {
 
     /**
      * Constructor for AddCommand class.
      *
      * @param command String input by user.
      */
-    public AddCommand(String command){
+    public AddCommand(String command) {
         super(command);
     }
 

src/main/java/duke/logic/commands/DeleteCommand.java

@@ -9,7 +9,7 @@
 /**
  * Handles 'delete' commands input by user.
  */
-public class DeleteCommand extends Command{
+public class DeleteCommand extends Command {
 
     /**
      * Constructor for DeleteCommand class

src/main/java/duke/logic/commands/DoneCommand.java

@@ -9,7 +9,7 @@
 /**
  * Handles 'done' command input by user.
  */
-public class DoneCommand extends Command{
+public class DoneCommand extends Command {
 
     /**
      * Constructor for DoneCommand class.

src/main/java/duke/logic/commands/ExitCommand.java

@@ -12,7 +12,7 @@
 /**
  * Handles 'bye' command input by user.
  */
-public class ExitCommand extends Command{
+public class ExitCommand extends Command {
 
     /**
      * Constructor for ExitCommand class.

src/main/java/duke/logic/commands/ListCommand.java

@@ -11,7 +11,7 @@
 /**
  * Handles 'list' command input by user.
  */
-public class ListCommand extends Command{
+public class ListCommand extends Command {
 
     /**
      * Constructor for ListCommand class.

src/main/java/duke/model/TaskManager.java

@@ -34,7 +34,7 @@ public TaskManager(ArrayList<Task> taskList) {
      *
      * @param task Task to be added.
      */
-    public void addTask(Task task){
+    public void addTask(Task task) {
         taskList.add(task);
     }
 

src/main/java/duke/storage/Storage.java

@@ -8,6 +8,7 @@
 import java.time.LocalDate;
 import java.util.ArrayList;
 
+import duke.exceptions.DukeException;
 import duke.model.task.Deadline;
 import duke.model.task.Event;
 import duke.model.task.Task;
@@ -24,7 +25,7 @@ public class Storage {
      *
      * @param saveFilePath Location of save file.
      */
-    public Storage(String saveFilePath){
+    public Storage(String saveFilePath) {
         this.saveFilePath = saveFilePath;
     }
 
@@ -53,7 +54,7 @@ public void save(ArrayList<Task> taskList) throws IOException {
      * @return ArrayList of Tasks.
      * @throws IOException If unable to access or find the save file.
      */
-    public ArrayList<Task> load() throws IOException {
+    public ArrayList<Task> load() throws IOException, DukeException {
         ArrayList<Task> taskList = new ArrayList<>();
         BufferedReader br = new BufferedReader(new FileReader(saveFilePath));
         String line;
@@ -74,6 +75,9 @@ public ArrayList<Task> load() throws IOException {
                 LocalDate eventDate = LocalDate.parse(taskLine[3]);
                 Event event = new Event(taskLine[2], Boolean.parseBoolean(taskLine[1]), eventDate);
                 taskList.add(event);
+                break;
+            default:
+                throw new DukeException("Error parsing save file.");
             }
         }
         return taskList;

src/main/java/duke/ui/Ui.java

@@ -9,9 +9,9 @@
  * Deals with user interactions.
  */
 public class Ui {
-    private final String WELCOME = "Hello. I am Claude! What may I do for you today?";
-    private final String GOODBYE = "Goodbye! Hope to see you again soon!";
-    private final String LINE = "______________________________";
+    static final String WELCOME = "Hello. I am Claude! What may I do for you today?";
+    static final String GOODBYE = "Goodbye! Hope to see you again soon!";
+    static final String LINE = "______________________________";
     private Scanner sc;
 
     public Ui() {
@@ -24,7 +24,7 @@ public Ui() {
      * @return String to be processed by parser.
      */
     public String readCommand() {
-        if (sc.hasNext()){
+        if (sc.hasNext()) {
             return sc.nextLine();
         } else {
             return "";
@@ -64,9 +64,9 @@ public void showDetails(String s) {
      * Prints a given ArrayList of Tasks.
      * @param taskList ArrayList of Tasks to be printed.
      */
-    public void showTaskList(ArrayList<Task> taskList){
+    public void showTaskList(ArrayList<Task> taskList) {
         String s = "";
-        for (int i= 0; i < taskList.size(); i++) {
+        for (int i = 0; i < taskList.size(); i++) {
             s = s = s + (i + 1) + ". " + taskList.get(i) + "\n";
         }
         showDetails(s);