Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bits #1115

Merged
merged 63 commits into from
Jan 23, 2025
Merged

Get bits #1115

merged 63 commits into from
Jan 23, 2025

Conversation

danielhrisca
Copy link
Owner

No description provided.

@zariiii9003
Copy link
Contributor

I see you're getting a linker error with Python 3.9, because Py_NewRef was added to stable ABI in 3.10.

You can change the configuration, so python 3.9 builds a version specific wheel and 3.10+ builds an ABI3 wheel.
Change this line in pyproject.toml: wheel.py-api = "cp310" and change your CMakeLists.txt like this:

if(NOT "${SKBUILD_SABI_COMPONENT}" STREQUAL "")
    set(PY_ABI_OPTIONS "WITH_SOABI" "USE_SABI" "3.10")
else()
    set(PY_ABI_OPTIONS "")
endif()
python_add_library(cutils MODULE src/asammdf/blocks/cutils.c ${PY_ABI_OPTIONS})

@danielhrisca danielhrisca merged commit a0a250d into development Jan 23, 2025
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants