fix: tox does not install extras if they have underscores in their name #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienGrv
changed the title
JulienGrv
force-pushed
the
bugfix/wrong-nameing-for-optional-dependencies
branch
from
cc08c9d to
e13ebcd
Compare
JulienGrv
changed the title
JulienGrv
changed the title
JulienGrv
force-pushed
the
bugfix/wrong-nameing-for-optional-dependencies
branch
from
e13ebcd to
ce15ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to using hyphens instead of underscores fixes the issue. Underscores are replaced with hyphens anyway when packaging asammdf because the standard from pypa does not accept underscore: https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata-provides-extra
For pip install, it will still continue to work for users using underscores because pip replaces the underscores with hyphens automatically.
Ready for merge