Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector synth #41

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

vector synth #41

wants to merge 7 commits into from

Conversation

vsandstrom
Copy link

Synth wrapper around VOsc object. Allows for seamless scrolling through consecutive buffers of wavetables.

@danielmkarlsson
Copy link
Owner

danielmkarlsson commented Apr 29, 2024

Howdy!
Great work on this.
It sounds absolutely stellar!

Couple things:

• The end parameter name is already being used somewhere else.

• The built in folding sounds great, but, I'd like to drive it some other way (unique parameter name to this synth) than with amp as is the case now. Might be nice to offer amplitude compensation like in the sha param for the waveshaping instance effect also, let's discuss.

• How would you feel about not exposing buf and bufn and instead taking care of that stuff under the hood.

@vsandstrom
Copy link
Author

Howdy! Great work on this. It sounds absolutely stellar!

Couple things:

• The end parameter name is already being used somewhere else.

• The built in folding sounds great, but, I'd like to drive it some other way (unique parameter name to this synth) than with amp as is the case now. Might be nice to offer amplitude compensation like in the sha param for the waveshaping instance effect also, let's discuss.

• How would you feel about not exposing buf and bufn and instead taking care of that stuff under the hood.

I think the buf and bufn arguments are hard to handle under the hood, since the wavetables are using the same buffers as all other samples used by supakleen. The synth needs to know which bufnum is the start of the consecutive buffers allocated with wavetables, and also how many there are to be able to handle morphing between them under the hood.

Could vbeg and vend be replacements for beg and end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants