Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 refactor: Revamp Model and Tool Filtering Logic #5637

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Feb 3, 2025

Summary

I updated the model filtering logic, added support for o3-mini Azure streaming, and enhanced tool filtering to ensure accurate inclusion and exclusion criteria in LibreChat that was affecting the Calculator and YouTube tools (basic tools and toolkits).

  • Updated ModelService to correctly filter out audio and realtime models, while including all Omni series models (openai)
  • Supported o3-mini Azure streaming in OpenAIClient by refining the stream drop behavior necessary for non-streaming omni models
  • Enhanced ToolService filtering logic by adjusting tool naming and matching to enforce proper inclusion and exclusion of basic tools and toolkits.

Change Type:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I adhered to the project’s style guidelines.
  • I performed a self-review of my code.
  • I commented on complex areas.
  • I made pertinent documentation changes.
  • My changes do not introduce new warnings.
  • I wrote tests demonstrating the effectiveness of my changes.
  • Local unit tests pass with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@danny-avila danny-avila merged commit 0312d4f into main Feb 3, 2025
2 checks passed
@danny-avila danny-avila deleted the fix/minor-issues-v2 branch February 3, 2025 21:08
justinmdickey pushed a commit to e-gineering/LibreChat that referenced this pull request Feb 7, 2025
* 🔧 fix: Update regex to correctly match OpenAI model identifiers

* 🔧 fix: Enhance tool filtering logic in ToolService to handle inclusion and exclusion criteria for basic tools and toolkits

* feat: support o3-mini Azure streaming

* chore: Update model filtering logic to exclude audio and realtime models

* ci: linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant