Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16980 cq: Bump python-packages in requirements.txt #15760

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DAOS-16980 cq: Bump python-packages in requirements.txt #15760

wants to merge 2 commits into from
+4 −2

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2025 •
edited
Loading

Bumps the python-packages group with 5 updates in the / directory:

Package From To
pylint 3.3.2 3.3.3
codespell 2.3.0 2.4.0

Updates avocado-framework from 82 to 109.0

Release notes

Sourced from avocado-framework's releases.

109.0

No release notes provided.

108.0

No release notes provided.

107.0

No release notes provided.

106.0 - Taking Off

The Avocado team is proud to present another release: Avocado 106.0, AKA "Taking Off", is now available!

Release documentation: Avocado 106.0

Users/Test Writers

  • The usage of Coverage.py (the de-facto Python tool for for test coverage) with Avocado received a number of improvements such as support for python-unittest tests in addition to avocado-instrumented tests.

  • When listing tests with avocado -V list, the resolver that handled the reference to test resolution is now shown. The reason is that with the introduction of resolvers such as runnable-recipe and runnables-recipe the resolver may not be the same as the test type.

  • Job log files can now use a memory buffer to reduce I/O pressure when there's much log activity. Users can set the job.run.logging_buffer_size with the desired buffer size.

Utility Modules

  • avocado.utils.disk.get_io_scheduler_list: new utility function that returns the I/O scheduler available for the I/O device.

  • avocado.utils.disk.get_io_scheduler: new utility function that returns the I/O scheduler which is currently set for a device.

Bug Fixes

  • The resolver could fail to check file permissions on systems such as macOS due to limitations in os.access. A more robust check is now used based on os.stat.

... (truncated)

Commits

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Ticket title is 'Update python requirements.txt - 2025-01-21'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16980

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15760/1/execution/node/1133/log

@dependabot
Bump the python-packages group across 1 directory with 5 updates
a326ab2 
Bumps the python-packages group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [avocado-framework](https://github.com/avocado-framework/avocado) | `82` | `109.0` |
| [avocado-framework-plugin-result-html](http://avocado-framework.github.io/) | `82` | `109.0` |
| [avocado-framework-plugin-varianter-yaml-to-mux](http://avocado-framework.github.io/) | `82` | `109.0` |
| [pylint](https://github.com/pylint-dev/pylint) | `3.3.2` | `3.3.3` |
| [codespell](https://github.com/codespell-project/codespell) | `2.3.0` | `2.4.0` |



Updates `avocado-framework` from 82 to 109.0
- [Release notes](https://github.com/avocado-framework/avocado/releases)
- [Commits](avocado-framework/avocado@82.0...109.0)

Updates `avocado-framework-plugin-result-html` from 82 to 109.0

Updates `avocado-framework-plugin-varianter-yaml-to-mux` from 82 to 109.0

Updates `pylint` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.3.2...v3.3.3)

Updates `codespell` from 2.3.0 to 2.4.0
- [Release notes](https://github.com/codespell-project/codespell/releases)
- [Commits](codespell-project/codespell@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: avocado-framework
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: python-packages
- dependency-name: avocado-framework-plugin-result-html
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: python-packages
- dependency-name: avocado-framework-plugin-varianter-yaml-to-mux
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: python-packages
- dependency-name: pylint
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-packages
- dependency-name: codespell
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-packages
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/python-packages-6829157440 branch from 4fb98b5 to a326ab2 Compare January 23, 2025 01:56
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15760/2/execution/node/1109/log

@daltonbohning
do not update avocado
4d9ca15 
add exclude pattern for avocado

Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning
daltonbohning reviewed Jan 23, 2025
View reviewed changes
utils/cq/requirements.txt
yamllint==1.35.1
codespell==2.3.0
codespell==2.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 This is why the codespell warnings crept in. Even though our GHA installs this requirements.txt, the workflow we use installs its own requirements, which pulls the latest codespell:
https://github.com/codespell-project/actions-codespell/blob/406322ec52dd7b488e48c1c4b82e2a8b3a1bf630/Dockerfile#L10

And I don't see an obvious way to configure that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would implementing codespell>=2.4.0 - similar to https://github.com/codespell-project/actions-codespell/blob/406322ec52dd7b488e48c1c4b82e2a8b3a1bf630/requirements.txt#L1 - solve this and also avoid a bunch of these tickets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might cut down on these PRs (I'm not sure if dependabot would still try to update when a newer version comes out).

But it doesn't solve the problem of new warnings.
For example:

  1. Someone has codespell 2.4.0, which is valid because codespell>=2.4.0
  2. They commit and push - no issues in the githooks
  3. The GHA runs with codespell 2.5.0, which is valid because codespell>=2.4.0
  4. The GHA fails because there are new warnings

To prevent this, the action we are using needs to support pinning the codespell version in some way

@daltonbohning daltonbohning changed the title Bump the python-packages group across 1 directory with 5 updates DAOS-16980 cq: Bump python-packages in requirements.txt Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@grom72 grom72 Awaiting requested review from grom72

@janekmi janekmi Awaiting requested review from janekmi

@ryon-jensen ryon-jensen Awaiting requested review from ryon-jensen

@phender phender Awaiting requested review from phender

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daosbuild1 @daltonbohning @phender