Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16834 test: Support testing MD on SSD Phase 2 #15767

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DAOS-16834 test: Support testing MD on SSD Phase 2 #15767

wants to merge 4 commits into from
+101 −17

Conversation

phender
Copy link
Contributor

@phender phender commented Jan 22, 2025

Add support for the dmg pool create --mem-ratio argument and enable testing MD on SSD Phase 2 on a few functional tests. Tests run with the launch.py --nvme=auto_md_on_ssd argument will be executed with an extra yaml file enabling the muxing of two /run/launhc/nvme branches which can then be used by tests to repeat testing with pools created with and without the --mem-ratio dmg pool create argument.

Skip-unit_tests: true
Skip-fault-injection-test: true
Test-tag: MdtestSmall IorSmall
Skip-func-hw-test-medium-md-on-ssd: false

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16834 test: Support testing MD on SSD Phase 2
c13d39c 
Add support for the dmg pool create --mem-ratio argument and enable
testing MD on SSD Phase 2 on a few functional tests.  Tests run with the
launch.py --nvme=auto_md_on_ssd argument will be executed with an extra
yaml file enabling the muxing of two /run/launhc/nvme branches which
can then be used by tests to repeat testing with pools created with and
without the --mem-ratio dmg pool create argument.

Skip-unit_tests: true
Skip-fault-injection-test: true
Test-tag: MdtestSmall IorSmall
Skip-func-hw-test-medium-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@github-actions GitHub Actions
Copy link

Ticket title is 'Support running existing tests in MD on SSD stages with two pool variants'
Status is 'In Progress'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16834

@phender
Fix yaml lint issues.
af53a32 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: MdtestSmall IorSmall
Skip-func-hw-test-medium-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15767/2/execution/node/920/log

@phender
Fix linting.
457c5de 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: MdtestSmall IorSmall
Skip-func-hw-test-medium-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15767/3/testReport/

@phender
Fix pool params.
ec0cf23 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: MdtestSmall IorSmall
Skip-func-hw-test-medium-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender phender marked this pull request as ready for review January 23, 2025 22:07
@phender phender requested review from a team as code owners January 23, 2025 22:07
@phender phender requested a review from daltonbohning January 23, 2025 22:07
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15767/4/testReport/

daltonbohning
daltonbohning reviewed Jan 23, 2025
View reviewed changes
src/tests/ftest/util/launch_utils.py
@@ -1137,6 +1142,30 @@ def _add_auto_storage_yaml(self, logger, storage_info, yaml_dir, tier_0_type, sc
# Allow extra yaml files to be to override the generated storage yaml
test.extra_yaml.insert(0, engine_storage_yaml[engines])

def _add_launch_param_yaml(self, logger, yaml_dir):
"""Add extra yaml for multiplexation launch parameter branches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong-spelling-in-docstring, Wrong spelling of a word 'multiplexation' in a docstring:

Either add to words.dict or change to a different word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @daosbuild1 @daltonbohning