Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New workflow diagram and align workflow code & naming #4529

Merged
merged 4 commits into from
Feb 14, 2025
Merged

New workflow diagram and align workflow code & naming #4529

merged 4 commits into from
Feb 14, 2025

Conversation

marcduiker
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR adds new workflow diagram with the activities and business logic. The workflow code and naming is now aligned across the languages.

Issue reference

#4520

@hhunter-ms hhunter-ms added this to the 1.15 milestone Feb 12, 2025
msfussell
msfussell reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An amazing PR! Question. What was the need to change the head.html file?

daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md Outdated Show resolved Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md Outdated Show resolved Hide resolved
@marcduiker marcduiker closed this Feb 13, 2025
@marcduiker
Update Workflow quickstarts so they all have the samae implementation…
3b09da1 
… and naming.

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
@marcduiker
Create head partial to remove outdated google analytics
ed98298 
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
@marcduiker marcduiker reopened this Feb 13, 2025
@marcduiker marcduiker marked this pull request as ready for review February 13, 2025 14:03
@marcduiker marcduiker requested review from a team as code owners February 13, 2025 14:03
@marcduiker
Copy link
Contributor Author

An amazing PR! Question. What was the need to change the head.html file?

The docsy head still contained GoogleAnaytics scripts that don't exist any longer. And this prevented hugo server to run. So I copied the docsy head partial and removed the outdated GoogleAnalytics lines.

msfussell
msfussell approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 134eaca into dapr:v1.15 Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees

@marcduiker marcduiker

Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@marcduiker @msfussell @hhunter-ms